chore(*): add gosec #94
Conversation
btcclient/query.go
Outdated
| @@ -34,7 +38,11 @@ func (c *Client) GetBlockByHash(blockHash *chainhash.Hash) (*types.IndexedBlock, | |||
| } | |||
|
|
|||
| btcTxs := types.GetWrappedTxs(mBlock) | |||
| return types.NewIndexedBlock(int32(blockInfo.Height), &mBlock.Header, btcTxs), mBlock, nil | |||
| height := blockInfo.Height | |||
| if height < 0 || height > int64(^uint32(0)) { | |||
There was a problem hiding this comment.
it seems a bit overkill and removing this check and running make gosec-local does not errors 🤔
There was a problem hiding this comment.
Are you sure? Because it does for me:
There was a problem hiding this comment.
I will clean cache and try again
There was a problem hiding this comment.
yeap, for me it doesn't appear the error
$~ make gosec-local
Results:
Summary:
Gosec : 2.20.0
Files : 90
Lines : 10303
Nosec : 5
Issues : 0There was a problem hiding this comment.
Did you do any other configuration?
There was a problem hiding this comment.
Got it, I was on a "dev" version. Fixed, thanks @RafilxTenfen
There was a problem hiding this comment.
Ah now the CI fails, so seems that we do need it, as our CI used the latest version. I'll be reverting this code then. And you should upgrade to latest version of gosec (2.21.4).
Summary:
Gosec : dev
Files : 90
Lines : 10287
Nosec : 5
Issues : 2
There was a problem hiding this comment.
curl -sfL https://raw.githubusercontent.com/securego/gosec/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v2.21.4
And try again @RafilxTenfen
| @@ -37,6 +37,9 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) | |||
|
|
|||
| ## Unreleased | |||
|
|
|||
| * [#94](https://github.com/babylonlabs-io/vigilante/pull/94) adds gosec and fixes gosec issues | |||
|
|
|||
config/submitter.go
Outdated
| if cfg.PollingIntervalSeconds < 0 { | ||
| return errors.New("invalid polling-interval-seconds, should not be less than 0") | ||
| } |
There was a problem hiding this comment.
| if cfg.PollingIntervalSeconds < 0 { | |
| return errors.New("invalid polling-interval-seconds, should not be less than 0") | |
| } | |
| if cfg.PollingIntervalSeconds <= 0 { | |
| return errors.New("invalid polling-interval-seconds, should be positive") | |
| } |
| @@ -143,6 +144,9 @@ func (m *Monitor) Start(baseHeight uint32) { | |||
| } else if !exists { | |||
| startHeight = baseHeight | |||
| } else { | |||
| if dbHeight > math.MaxUint32 { | |||
There was a problem hiding this comment.
seems in some places we use math.MaxUint32 and in other places we use ^uint32(0). Are they the same? If so, should we keep using one?
Adds gosec